Use String#append_as_bytes if available
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Final version of: #116 Ref: https://bugs.ruby-lang.org/issues/20594 This isn't yet as fast as the prototype because the final method was merged as `append_as_bytes` with variadic and Integer support so I haven't implemented a YJIT acceleration yet. But since we can now consider the interface stable, we can merge.
rwstauner
force-pushed
the
append-as-bytes
branch
from
a6bf961 to
fda769f
Compare
|
I rebased to fix CI |
|
Thanks @casperisfine and @rwstauner ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final version of: #116
Ref: https://bugs.ruby-lang.org/issues/20594
This isn't yet as fast as the prototype because the final method was merged as
append_as_byteswith variadic and Integer support so I haven't implemented a YJIT acceleration yet.But since we can now consider the interface stable, we can merge.