Add theme profile command
#5109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dev shopify theme profile --url https://coded-courses.myshopify.com/` Only opens a browser page for now, no auth.
Coverage report
Show files with reduced coverage 🔻
Test suite run success1975 tests passing in 896 suites. Report generated by 🧪jest coverage report action from 4f84642 |
macournoyer
commented
Dec 16, 2024
ianks
reviewed
Dec 17, 2024
And use import.meta.resolve to load Speedscope
And strengthen how we resolve Speedscope
macournoyer
commented
Dec 18, 2024
Comment on lines
+33
to
+43
| if (import.meta.resolve) { | ||
| return import.meta.resolve('speedscope/dist/release/index.html') | ||
| } else { | ||
| try { | ||
| const speedscopePath = require.resolve('speedscope/package.json') | ||
| const speedscopeDir = speedscopePath.replace('/package.json', '') | ||
| return `file://${speedscopeDir}/dist/release/index.html` | ||
| } catch (error) { | ||
| throw new Error("Can't find Speedscope package") | ||
| } | ||
| } |
There was a problem hiding this comment.
Seems to work both in tests and with dev shopify. Is there some packaging magic that could make this not work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
https://hackdays.shopify.io/projects/19234
We want to expose Liquid profiling via:
The new
theme profilecommand will be called for both. The VSCode extensions will use the--jsonflag.WHAT is this pull request doing?
Add a
shopify theme profile --urlcommand that calls SFR asking for profiling data (using theAcceptheader).Left to do
--jsonarg.theme devcommand.How to test your changes?
Run
dev shopify theme profile --store [YOUR STORE DOMAIN] --url /. Should open a browser window with Speedscope in it.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist