RFC: Expand derivatives in initialization equations before dummy derivative mapping #3211
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vative mapping This handles cases like `D(-x) ~ 0` which can happen during the fixed point substitution The issue though is that if we have `D(y) ~ 0`, `y ~ -x`, then we need to substitute `D(-x) ~ 0` then change to `-D(x) ~ 0` and then substitute, so we need to somehow know to expand in the middle there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles cases like
D(-x) ~ 0which can happen during the fixed point substitutionThe issue though is that if we have
D(y) ~ 0,y ~ -x, then we need to substituteD(-x) ~ 0then change to-D(x) ~ 0and then substitute, so we need to somehow know to expand in the middle there.