chore: replace redundant useManagedState with Vue's defineModel #2529
Conversation
🦋 Changeset detectedLatest commit: 21148a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoCa96
force-pushed
the
joca96/remove-managed-state
branch
3 times, most recently
from
42ee9e0 to
7deab1a
Compare
JoCa96
changed the title
packages/sit-onyx/src/components/OnyxMiniSearch/OnyxMiniSearch.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/examples/FormExample/FormExample.vue
Outdated
Show resolved
Hide resolved
| @@ -3,6 +3,7 @@ | |||
| "include": ["src/**/*"], | |||
| "compilerOptions": { | |||
| "rootDir": "./src", | |||
| "lib": ["DOM", "DOM.Iterable", "ES2022"], | |||
There was a problem hiding this comment.
Why is this change needed? Same question for the playground
There was a problem hiding this comment.
Honestly, I don't know why it is needed now.
Without it, I am getting errors:
The errors make sense, but why only after all these seemingly unrelated changes?
My assumption is, that the Vue compiler can handle the updated typings better and doesn't bail out (as early)?
There was a problem hiding this comment.
Hmm shouldn't the headless code be inlined? Maybe this has something to do with the update to Vite 6 in #2530 ?
There was a problem hiding this comment.
JavaScript is inlined, the typings are not inlined afaik
There was a problem hiding this comment.
I don't think it is related, because there are no issues on main
There was a problem hiding this comment.
I think we should find out why and fix this, otherwise propably all projects using onyx will have build errors...
JoCa96
force-pushed
the
joca96/remove-managed-state
branch
from
a77be86 to
77d2951
Compare
| @@ -424,7 +423,6 @@ defineExpose({ input: computed(() => selectInput.value?.input) }); | |||
| value: option.value, | |||
| label: option.label, | |||
| disabled: option.disabled, | |||
| // TODO: remove type cast once its fixed in Vue / vue-tsc version | |||
| selected: arrayValue.some((value: TValue) => value === option.value), | |||
There was a problem hiding this comment.
| selected: arrayValue.some((value: TValue) => value === option.value), | |
| selected: arrayValue.some((value) => value === option.value), |
I guess the TODO was meant for this one
There was a problem hiding this comment.
the type hint here is still necessary
JoCa96
force-pushed
the
joca96/remove-managed-state
branch
from
6138353 to
21148a0
Compare
The changes are mostly internal, but the typings were of
OnyxSelecthave changed:modelValuenow infers a specific subtype ofSelectOptionValueand theoptionsvalues must match.withSearch: Filtering of the options will not automatically disabled anymore whensearchTermis bound. InsteadnoFiltermust be set.Arrayabletype, imported fromvitest, as it was an internal type. Replaced with our own type with the same name.MaybeReactiveSourcetype, as it is now covered by Vue'sMaybeRefOrGettertype