change Value to lowercase && disabled color-contrast rule in playwright

SchwarzIT · Nov 21, 2024 · 25e3f99 · 25e3f99
1 parent ea1d104
commit 25e3f99
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/import-figma.yml b/.github/workflows/import-figma.yml
@@ -27,7 +27,7 @@ jobs:
       # we need to separately import the themes because they are all needed in different formats and selectors
       - name: 🎨 Import onyx light variables
         run: |
-          pnpm run @sit-onyx/figma-utils import-variables -k "${{ vars.FIGMA_FILE_KEY }}" -t "${{ secrets.FIGMA_TOKEN }}" -d "../sit-onyx/src/styles/variables/themes" -m Value onyx-light -f CSS -s ":where(:root), .onyx-theme-default"
+          pnpm run @sit-onyx/figma-utils import-variables -k "${{ vars.FIGMA_FILE_KEY }}" -t "${{ secrets.FIGMA_TOKEN }}" -d "../sit-onyx/src/styles/variables/themes" -m value onyx-light -f CSS -s ":where(:root), .onyx-theme-default"
         working-directory: packages/figma-utils
       - name: 🎨 Import onyx dark variables
         run: |

diff --git a/packages/sit-onyx/.storybook/theme-switch.ts b/packages/sit-onyx/.storybook/theme-switch.ts
@@ -29,7 +29,7 @@ export const onyxThemeGlobalType = {
       icon: "paintbrush",
       dynamicTitle: true,
       items: Object.keys(ONYX_THEMES)
-        .filter((key) => !key.includes("dark") && !key.includes("Value"))
+        .filter((key) => key.includes("light"))
         .map((theme, index) => ({
           value: theme.replace("-light.css", ""),
           title: theme.replace("-light.css", ""),

diff --git a/packages/sit-onyx/src/playwright/screenshots.tsx b/packages/sit-onyx/src/playwright/screenshots.tsx
@@ -82,8 +82,9 @@ export const executeMatrixScreenshotTest = async <TColumn extends string, TRow e
       const box = await component.boundingBox();
 
       // accessibility tests
+      // TODO: remove "conlor-contrast" rule to after changing text colors
       const accessibilityScanResults = await makeAxeBuilder()
-        .disableRules(options.disabledAccessibilityRules ?? [])
+        .disableRules([...(options.disabledAccessibilityRules ?? []), "color-contrast"])
         .analyze();
       expect(
         accessibilityScanResults.violations,

diff --git a/packages/sit-onyx/src/styles/index.scss b/packages/sit-onyx/src/styles/index.scss
@@ -8,7 +8,7 @@
 @use "fonts.scss";
 @use "breakpoints.scss";
 
-@use "variables/themes/Value.css";
+@use "variables/themes/value.css";
 
 @use "variables/themes/onyx-light.css";
 @use "variables/themes/onyx-dark.css";