8.2.13

- D8CORE-4090 D8CORE-2888 D8CORE-4126: Accessibility fixes to the news (#124) (732b7eb) - D8CORE-3162: change the title of the news article in lists and cards (#123) (9b4f1cd)
SU-SWS · Jun 11, 2021 · fd26664 · fd26664
2 parents d71b258 + 9debee9
commit fd26664
Show file tree

Hide file tree

Showing 8 changed files with 244 additions and 60 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -4,10 +4,13 @@ version: 2
 ## Defines images and working directory.
 defaults: &defaults
   docker:
-    - image: pookmish/drupal8ci:pcov
+    - image: pookmish/drupal8ci:latest
     - image: selenium/standalone-chrome:latest
-    - image: mariadb:10.3
+    - image: circleci/mysql:5.7
       environment:
+        MYSQL_DATABASE: drupal
+        MYSQL_USER: drupal
+        MYSQL_PASSWORD: drupal
         MYSQL_ALLOW_EMPTY_PASSWORD: 1
   working_directory: /var/www/html
 

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -1,29 +1,66 @@
-# READY FOR REVIEW/NOT READY
+# NOT READY FOR REVIEW
 - (Edit the above to reflect status)
 
 # Summary
 - TL;DR - what's this PR for?
 
-# Needed By (Date)
-- When does this need to be merged by?
+# Review By (Date)
+- When does this need to be reviewed by?
+
+# Criticality
+- How critical is this PR on a 1-10 scale? Also see [Severity Assessment](https://stanfordits.atlassian.net/browse/D8CORE-1705).
+- E.g., it affects one site, or every site and product?
 
 # Urgency
-- How critical is this PR?
+- How urgent is this? (Normal, High)
+
+# Review Tasks
+
+## Setup tasks and/or behavior to test
+
+1. Check out this branch
+2. Rebuild Cache and import config `drush cr ; drush ci`
+3. Navigate to...
+4. Verify...
+
+### Site Configuration Sync
+
+- Is there a config:export in this PR that changes the config sync directory?
+
+## Front End Validation
+- [ ] Design is approved by @ user?
+- [ ] HTML validation: Is the markup using the appropriate semantic tags and [passes validation](https://validator.w3.org/nu/)? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
+- [ ] Cross-browser testing: Has been performed? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
+- [ ] Automated accessibility: Scans performed? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
+- [ ] Manual accessibility: Manually tested? Or, [QA request ticket created](https://github.com/SU-SWS/template_warehouse/blob/master/jira_templates/QA_request_template.txt)?
+
+## Backend / Functional Validation
+### Code
+- [ ] Are the naming conventions following our standards?
+- [ ] Does the code have sufficient inline comments?
+- [ ] Is there anything in this code that would be hidden or hard to discover through the UI?
+- [ ] Are there any [code smells](https://blog.codinghorror.com/code-smells/)?
+- [ ] Are tests provided? eg (unit, behat, or codeception)
 
-# Steps to Test
+### Code security
+- [ ] Are all [forms properly sanitized](https://www.drupal.org/docs/8/security/drupal-8-sanitizing-output)?
+- [ ] Any obvious [security flaws or new areas for attack](https://www.drupal.org/docs/8/security)?
 
-1. Do this
-1. Then this
-2. Then this
+## General
+- [ ] Is there anything included in this PR that is not related to the problem it is trying to solve?
+- [ ] Is the approach to the problem appropriate?
 
 # Affected Projects or Products
 - Does this PR impact any particular projects, products, or modules?
 
 # Associated Issues and/or People
-- JIRA ticket
+- JIRA ticket(s)
 - Other PRs
 - Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
 - Anyone who should be notified? (`@mention` them here)
 
-# See Also
-- [PR Checklist](https://gist.github.com/sherakama/0ba17601381e3adbe0cad566ad4d80a5)
+# Resources
+- [AMP Tool](https://stanford.levelaccess.net/index.php)
+- [Accessibility Manual Test Script](https://docs.google.com/document/d/1ZXJ9RIUNXsS674ow9j3qJ2g1OAkCjmqMXl0Gs8XHEPQ/edit?usp=sharing)
+- [HTML Validator](https://validator.w3.org/)
+- [Browserstack](https://live.browserstack.com/dashboard) and link to [Browserstack Credentials](https://asconfluence.stanford.edu/confluence/display/SWS/External+Account+Credentials)
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Stanford News
 
+8.x-2.13
+--------------------------------------------------------------------------------
+_Release Date: 2021-06-11_
+
+- D8CORE-4090 D8CORE-2888 D8CORE-4126: Accessibility fixes to the news (#124) (732b7eb)
+- D8CORE-3162: change the title of the news article in lists and cards (#123) (9b4f1cd)
+
 8.x-2.12
 --------------------------------------------------------------------------------
 _Release Date: 2021-05-07_

diff --git a/composer.json b/composer.json
@@ -99,7 +99,7 @@
         "drupal/views_infinite_scroll": "^1.6",
         "drupal/views_taxonomy_term_name_depth": "^7.0",
         "su-sws/drupal-patches": "^8.0",
-        "su-sws/jumpstart_ui": "^8.1.0",
-        "su-sws/stanford_text_editor": "^8.1.0"
+        "su-sws/jumpstart_ui": "^8.1",
+        "su-sws/stanford_text_editor": "^8.1"
     }
 }
diff --git a/dist/css/news-list-item.css b/dist/css/news-list-item.css
diff --git a/lib/scss/components/news-list-item/_list-item.scss b/lib/scss/components/news-list-item/_list-item.scss
@@ -44,24 +44,77 @@
 }
 
 .su-news-list {
-  @include margin(0);
-  @include padding(0);
-  @include modular-spacing('padding', 4 null);
-
   list-style: none;
   overflow: auto;
-  border-bottom: 1px solid $su-color-cool-grey-25;
+  padding-left: 0;
 
-  .su-news-list__item__date {
-    @include small-paragraph;
+  li {
+    &:first-of-type {
+      > article {
+        padding-top: 0;
+      }
+    }
   }
 
-  .media {
-    @include modular-spacing('margin-left', 3);
-    float: right;
+  //List grid set up
+  .su-news-list__item-date {
+    grid-area: date;
+  }
+
+  .image {
+    grid-area: article-image;
+  }
+
+  .su-news-list__headline-dek {
+    grid-area: headline;
+  }
+
+  .su-news-list__header {
 
     @include grid-media-max('lg') {
-      display: none;
+      display: grid;
+      grid-template-columns: 100%;
+      grid-template-areas: "date" "headline" "dek";
+    }
+
+
+    @include grid-media-min('xl') {
+      display: grid;
+      grid-template-columns: 65% 35%;
+      grid-template-areas: "date date" "headline article-image" "headline article-image";
+    }
+  }
+
+  .su-news-list-image__empty {
+    .su-news-list__header {
+      display: grid;
+      grid-template-columns: 100%;
+      grid-template-areas: "date" "headline" "dek";
+    }
+  }
+
+  .su-news-article {
+    @include margin(0);
+    @include padding(0);
+    @include modular-spacing('padding', 4 null);
+
+    border-bottom: 1px solid $su-color-cool-grey-25;
+  }
+
+
+  .su-news-list__item-date {
+    @include small-paragraph;
+
+    order: -1;
+  }
+
+  .image {
+    .media {
+      @include modular-spacing('margin-left', 3);
+
+      @include grid-media-max('lg') {
+        display: none;
+      }
     }
   }
 
@@ -71,17 +124,74 @@
 
     color: $su-color-bright-red;
     text-decoration: none;
+
+    &:focus,
+    &:visited,
+    &:active,
+    &:hover {
+      text-decoration: underline;
+    }
   }
 
   h2 {
     @include modular-spacing('margin-bottom', 1);
+    @include modular-typography(2);
 
     display: inline;
+
+    &:focus {
+      outline: none;
+    }
+  }
+
+  .su-link--external {
+    &::after {
+      background-color: $su-color-bright-red;
+      height: 1.8rem;
+      width: 1.8rem;
+    }
   }
 
   .su-news-list__dek {
     @include big-paragraph;
-    @include modular-spacing('margin-bottom', 2);
+    @include modular-spacing('margin-bottom', 1);
+    @include modular-spacing('margin-top', -1);
+
+  }
+
+  ul {
+    list-style: none;
+    overflow: auto;
+    padding-bottom: 0;
+    padding-left: 0;
+
+    li {
+      @include responsive-spacing('padding-right', -1);
+
+      display: inline-block;
+
+      &::after {
+        content: ", ";
+      }
+    }
+
+    li:last-of-type {
+      &::after {
+        content: "";
+      }
+    }
+  }
+}
+
+// Unset the widths of h2 for paragraphs
+.container-2-items,
+.container-3-items {
+  .paragraph--type--stanford-lists {
+    .su-news-list {
+      h2 {
+        max-width: unset;
+      }
+    }
   }
 }
 
@@ -131,7 +241,7 @@
   }
 }
 
-.su-news-list__footer {
+.su-news-edit-article {
   a {
     @include button-secondary;
     text-align: right;

diff --git a/stanford_news.info.yml b/stanford_news.info.yml
@@ -3,7 +3,7 @@ type: module
 description: 'Stanford news items and views.'
 core_version_requirement: ^8.8 || ^9
 package: Stanford
-version: 8.x-2.12
+version: 8.x-2.13
 dependencies:
   - allowed_formats:allowed_formats
   - auto_entitylabel:auto_entitylabel