Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cf-deploy): adds @sap-ux/cf-deploy-config-sub-generator #2792

Merged
merged 19 commits into from
Jan 20, 2025
Merged

feat(cf-deploy): adds @sap-ux/cf-deploy-config-sub-generator #2792

merged 19 commits into from
Jan 20, 2025
+1,622 −102

Conversation

cianmSAP
Copy link
Contributor

@cianmSAP cianmSAP commented Jan 16, 2025 •
edited
Loading

#2783

  • Adds new module @sap-ux/cf-deploy-config-sub-generator. This new module will contain both sub generators - app router, cf deploy configuration
  • This PR adds the App Router Configuration Generator only
  • Also fixes issues with error messages not loading i18n's in deploy config shared due to static properties loading before i18n

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: dbce4af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP marked this pull request as ready for review January 17, 2025 10:27
@cianmSAP cianmSAP requested a review from a team as a code owner January 17, 2025 10:27
IainSAP
IainSAP approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP

  • Code is clear
  • Test coverage is good
  • Not tested locally

devinea
devinea approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module setup looks good and changeset

longieirl
longieirl approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mta and output tests look good.
Test coverage is good.
Changes look good overall.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cianmSAP cianmSAP merged commit 6b6c64a into main Jan 20, 2025
16 checks passed
@cianmSAP cianmSAP deleted the feat/cf-deploy-sub-gen branch January 20, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IainSAP IainSAP IainSAP approved these changes

@devinea devinea devinea approved these changes

@longieirl longieirl longieirl approved these changes

@kjose90 kjose90 Awaiting requested review from kjose90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cianmSAP @longieirl @devinea @IainSAP