Move cap updates to generate functions of FE/FF #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 811810b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…into moveCapUpdates
|
devinea
approved these changes
Jan 17, 2025
IainSAP
reviewed
Jan 17, 2025
| app: FioriApp; | ||
| appOptions: Partial<AppOptions> & { | ||
| /** | ||
| * Generate OPA based tests, if applicable to the specified template. | ||
| * This will eventually move up to {@link Ui5App.appOptions} | ||
| */ | ||
| addTests?: boolean; | ||
| enableNPMWorkspaces?: boolean; |
There was a problem hiding this comment.
Could you please add a detailed description of how this works as you cannot enabledNPMWorkspaces on an app so its confusing. Please also note thats this is dependant on the service being of type capService. You could even link the doc to the description/defintion from the cap writer?
IainSAP
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2787
generatefunctions of FE/FFcapService& addedenableNPMWorkspacestoappOptionsof FE/FF