Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce ADP FLP config generator #2730

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

mmilko01
Copy link
Contributor

@mmilko01 mmilko01 commented Dec 20, 2024

#2727

Introduce standalone FLP configuration generator for Adaptation Projects

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 7805c6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/adp-tooling Patch
@sap-ux/i18n Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/project-access Patch
@sap-ux/app-config-writer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/annotation-generator Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cards-editor-middleware Patch
@sap-ux/cf-deploy-config-writer Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/launch-config Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/project-integrity Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/inquirer-common Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/ui5-library-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code the new package looks good

@testojs testojs self-requested a review January 8, 2025 08:23
@mmilko01 mmilko01 added adp-tooling feature New feature or request labels Jan 8, 2025
@mmilko01 mmilko01 marked this pull request as ready for review January 8, 2025 12:26
@mmilko01 mmilko01 requested review from a team as code owners January 8, 2025 12:26
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
17.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adp-tooling feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants