Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a lot of broken or incorrect generators #111

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Fix a lot of broken or incorrect generators #111

merged 11 commits into from
Oct 24, 2023

Conversation

Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Oct 20, 2023 •
edited
Loading

Why?

Following the instructions in the README and running the generate all command was not working out of the box. This aims at fixing a majority of the issues.

Fixes #106
Addresses some things in #100

What Changed

  • Make the React Generator Optional. Since a lot of our newer projects don't use React, running the all command will ask if you want it.
  • Update the eslint generator to use the latest ecmascript setting. Fixed the injected package command. Also cleaned up some of our templates to not generate with warnings.
  • Fix semaphore generator yml commands for webpack
  • Update the README to instruct with the correct rails new command and also list all the generators that exist.
  • Fix the Devise saas generator to not crash when installing bcrypt.
  • Fix the rubocop generator to put the custom cop in lib/cops/... instead of app since the linter expected it to be in lib.
  • Add rubymines idea folder to .gitignore file

@Jeremy-Walton Jeremy-Walton added bug Something isn't working enhancement New feature or request labels Oct 20, 2023
@Jeremy-Walton Jeremy-Walton self-assigned this Oct 20, 2023
Braden-077
Braden-077 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@Braden-077 Braden-077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment on this is that we should add one directory to the .gitignore in the Github generator. /.idea is a RubyMine specific set of files which is obnoxious and irrelevant.

@Jeremy-Walton Jeremy-Walton mentioned this pull request Oct 20, 2023
Open
5 tasks
@Jeremy-Walton Jeremy-Walton linked an issue Oct 20, 2023 that may be closed by this pull request
New rails 7 generator issues recently found #100
Open
5 tasks
@Jeremy-Walton Jeremy-Walton merged commit 6590ae0 into master Oct 24, 2023
@Jeremy-Walton Jeremy-Walton deleted the make-it-work branch October 24, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Braden-077 Braden-077 Braden-077 approved these changes

@justwiebe justwiebe justwiebe approved these changes

@mark-kraemer mark-kraemer mark-kraemer approved these changes

@OutlawAndy OutlawAndy Awaiting requested review from OutlawAndy

Assignees

@Jeremy-Walton Jeremy-Walton

Labels
bug Something isn't working enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rails 7 generator issues recently found Steps Needed to make the Generator Work in a new project
4 participants
@Jeremy-Walton @mark-kraemer @justwiebe @Braden-077