Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rails 7 generator issues recently found #100

Open
2 of 5 tasks
mark-kraemer opened this issue May 31, 2023 · 5 comments · Fixed by #111
Open
2 of 5 tasks

New rails 7 generator issues recently found #100

mark-kraemer opened this issue May 31, 2023 · 5 comments · Fixed by #111
Assignees

Comments

@mark-kraemer
Copy link
Member

mark-kraemer commented May 31, 2023

Webpack Generator:

  • The file /Users/markkraemer/Sites/rolemodel/engage-learn/app/javascript/application.js does not appear to exist failure will break the generator and prevent it from continuing
  • "build": "webpack --config webpack.config.js" is not injected into the existing package.json file
  • jsbundling-rails gem needs to be added to the gemfile, followed by running bin/rails javascript:install:webpack
  • stimulus-rails gem should be added to the gemfile. This gem provides the stimulus generator & the stimulus:manifest:update task for auto generating the app/javascript/controllers/index.js file
  • app/javascript/controllers/application.js template (see below)
@OutlawAndy
Copy link
Member

app/javascript/controllers/application.js

import { Application } from "@hotwired/stimulus"

const application = Application.start()

application.debug = process.env.NODE_ENV === 'development'
window.Stimulus   = application

export { application }

@Braden-077
Copy link
Member

Braden-077 commented Jun 16, 2023

  • Fix Mailer Generator (issues with styling)
  • Update Semaphore Generator with ubuntu2004
  • Optics incorrect imports (Modal/Panel styles)
  • Fix RuboCop Generator to include rubocop-rails

@Braden-077 Braden-077 self-assigned this Jun 16, 2023
@Jeremy-Walton Jeremy-Walton mentioned this issue Jun 23, 2023
2 tasks
@justwiebe
Copy link

I could just be doing things wrong, but when I run the rolemodel:all on a fresh project, I get an error

An error occurred while installing bcrypt (3.1.19), and Bundler cannot continue.

In Gemfile:
  devise was resolved to 4.9.2, which depends on
    bcrypt
    generate  devise:install
       rails  generate devise:install
Could not find bcrypt-3.1.19 in locally installed gems
Run `bundle install` to install missing gems.

@Jeremy-Walton
Copy link
Member

#107 Is now merged which addressed some of these things.

@BakoviDagi Yeah things unfortunately don't just "work" out of the box. Not sure what causes it but definitely worth investigation.

@Jeremy-Walton
Copy link
Member

#111 Is fixing a bunch of these.

"build": "webpack --config webpack.config.js" is not injected into the existing package.json file.
@mark-kraemer ^ is fixed by including --javascript=webpack when using rails new. That is now in the README.

@BakoviDagi The devise install is fixed.

@Braden-077 All your items are also fixed

I did not address some of the other webpack issues.

@Jeremy-Walton Jeremy-Walton linked a pull request Oct 20, 2023 that will close this issue
7 tasks
@Jeremy-Walton Jeremy-Walton reopened this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

5 participants