-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor graphical bug fixes for Linux. #1839
Conversation
I went through the request and I saw several changes which from my understanding are just a result of testing and toying around in order to narrow down the bug.
|
The changes in This moves the call to The change in |
|
My guess would be that in changeScreenMode: |
Okay your changes lead to immediatly crashes on my end. |
Does GLES not work on Windows? I set that as a general code cleanup thing, since that's the common denominator between all the platforms, since that's the set Commander Wars uses in practice. I'm going to have to see if I can get it compiling on Android to make sure I don't break anything, at the very least. I'll put it on a minimum set of changes for now, and sort it out more when I can test stuff on more platforms. |
GLES crashes the game on my end at least. |
Tested on Linux: Not only does this work, but it clears the issue I was having earlier with it acting strangely on startup, despite me removing the change to remove the redundant mode switch. wtf. |
Rebased and fixed. I'll investigate further later, probs not a thing for this PR. |
This fixes a few small issues on Linux:
This also adds a flake.nix script to help build Commander Wars on NixOS/with Nix. I added this for my personal use, but no sense in not committing it.