correctly track element pointer in heap snapshot (#51592) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
port-to-v1.10
d-netto
removed
port-to-master
|
we probably want this on |
nickrobinson251
approved these changes
Oct 5, 2023
|
The bug (and corresponding fix) showed up as part of the GC changes from 1.10, so it's not present in 1.9. |
|
ah, awesome! thanks, Diogo! |
kpamnany
pushed a commit
that referenced
this pull request
Oct 19, 2023
kpamnany
pushed a commit
that referenced
this pull request
Oct 19, 2023
DelveCI
pushed a commit
that referenced
this pull request
Oct 20, 2023
kpamnany
removed
the
port-to-v1.10
kpamnany
pushed a commit
that referenced
this pull request
Oct 21, 2023
DelveCI
pushed a commit
that referenced
this pull request
Oct 23, 2023
DelveCI
pushed a commit
that referenced
this pull request
Nov 1, 2023
DelveCI
pushed a commit
that referenced
this pull request
Nov 2, 2023
DelveCI
pushed a commit
that referenced
this pull request
Nov 7, 2023
DelveCI
pushed a commit
that referenced
this pull request
Nov 10, 2023
DelveCI
pushed a commit
that referenced
this pull request
Nov 14, 2023
DelveCI
pushed a commit
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
A few fixes related to how we were tracking element pointers on heap snapshot. This PR also includes a fix related to chunking in array16: one optimization in which we pre-scan the array to avoid chunking too frequently is missing in our fork.
This fix showed up as part of cherry-picking JuliaLang#51592 to our fork, so that's why I'm including it here. But can open a separate PR with that.
Checklist
Requirements for merging:
port-to-*labels that don't apply.