Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements to 049 removing hazmat suit/714 #241

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ChronoQuote
Copy link

@ChronoQuote ChronoQuote commented Oct 8, 2022

Fixed + improved version of PR #179.

Before: https://streamable.com/cb18y1

After: https://streamable.com/v75oqp

4fe0648 Fixes and improvements to 049 removing hazmat suit/714

  • Use two new globals as removal timers instead of BlurTimer, which fixes the issue where having blurry vision from another source (e.g. 420-J) causes 049 to remove the hazmat suit/714 sooner, as well as the issue where wearing both items at once causes 049 to only spend time removing the hazmat suit
  • Hazmat suit now falls to the ground when removed by 049 instead of being inexplicably destroyed
  • 714 now falls to the ground when removed by 049 instead of remaining in player's inventory (not that it matters much since the player dies afterwards)
  • Add messages to make it clear to the player when an item is removed
  • Make removal voice lines play sooner, replacing the initial awkward silence on contact and ensuring 049 is able to play a "kidnap" voice line on kill
  • Previously, PrevState represented whether 049 had played a removal voice line, but it would reset to 2 the moment you backed away from 049, and would not allow both removal voice lines to play if you were wearing both items at once; now, ChannelPlaying checks are used instead, preventing removal voice lines from being spammable by repeatedly approaching and backing away from 049, and also allowing both removal voice lines to play (edit: in general this makes 049 interrupt himself less, at the cost of a voice line potentially not playing, as seen at the end of the after video)

ffdb482 Remove ability to pick up items while dying

It was easy to pick up the dropped hazmat suit while dying after 049 removed it. This shouldn't be possible.

- Use two new globals as removal timers instead of BlurTimer, which fixes the issue where having blurry vision from another source (e.g. 420-J) causes 049 to remove the hazmat suit/714 sooner, as well as the issue where wearing both items at once causes 049 to only spend time removing the hazmat suit
- Hazmat suit now falls to the ground when removed by 049 instead of being inexplicably destroyed
- 714 now falls to the ground when removed by 049 instead of remaining in player's inventory (not that it matters much since the player dies afterwards)
- Add messages to make it clear to the player when an item is removed
- Make removal voice lines play sooner, replacing the initial awkward silence on contact and ensuring 049 is able to play a "kidnap" voice line on kill
- Previously, PrevState represented whether 049 had played a removal voice line, but it would reset to 2 the moment you backed away from 049, and would not allow both removal voice lines to play if you were wearing both items at once; now, ChannelPlaying checks are used instead, preventing removal voice lines from being spammable by repeatedly approaching and backing away from 049, and also allowing both removal voice lines to play
It was easy to pick up the dropped hazmat suit while dying after 049 removed it. This shouldn't be possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant