-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better pause menu: #192
base: dev
Are you sure you want to change the base?
Better pause menu: #192
Conversation
- Increased height of pause menu. Now it looks more proportionate; - Fixed an inaccuracy showing a map seed instead of selected map name while playing on selected map; - Made a capitalization of the buttons name which is more stylistically; - Moved some ticks closer to each other in "Advanced" tab; - Aligned buttons width; - Fixed an inaccuracy showing the "Load Game" button while playing on "Perma Death" mode; - Made a small spacing alignment between buttons; - Added forgotten scale factor on the line #7701.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING! Forgot to discard Ideal Parameters here!
Seems to me like the boxes in the advanced tab were spaced apart as a way of grouping them into categories. Also, AA text looks isolated in both the before and after... maybe it should be grouped like normal and only be moved down while the framelimit slider is visible? |
Well yeah, would be better to move AAText upper. It looks isolated because of Framelimit slidebar. Don't forget that slidebars don't have a rescale, so on lower resolutions it can be overlapped |
- The ``AAText`` checkbox has been moved closer to the others; - Added ``MenuGray`` texture for locked buttons, ticks, inputboxes and etc.; - Added ``ButtonSFX2`` sound while clicling on locked button or tick; - Added new parameter in ``DrawButton`` function called "locked" for easier adding locked buttons; - Moved down arrows in save and custom map menus; - Added ability to delete custom map; - Made a capitalization of the buttons name which is more stylistically (in Main Menu); - Reduce menu height when the ``Framelimit`` or ``Usertrack`` options are hidden; - Reduced the number of saves per page from 6 to 5; - Fixed being able to press the ``BACK`` button when deleting a save; - Fixed arrows shifting one pixel in the save and custom map menus; - Slightly improved input boxes design (used ``DrawFrame`` instead of ``Rect``, so they stylistically similar to buttons and ticks).
- A "Back" wasn't all caps - A "Page" wasn't all caps - Two "Screen gamma"s didn't have a colon - "Open/Close Inventory" was too long
- Center pause menu title text to match ending screen title text - Move user track mode text to right of tick box like it is in main menu - Declare TempStr as a local in menu drawing functions (and rename it to the more common strtemp) - Center save file and custom map info text - Fix SlideBar "LOW" and "HIGH" text being considerably lower than the bar
- Horizontally center "YES" and "NO" deletion confirmation buttons - Better align "ACHIEVEMENTS" and "MAIN MENU" buttons on ending screen - Make achievement menu page buttons square and add disabled buttons to match load game/load map page buttons
It looks perfect at native 1024p now, but due to rounding errors with the menu scaling system, some menu elements still get misaligned by 1px at higher resolutions... I think ideally all coordinates should be floats, and nothing should be multiplied by MenuScale until the moment buttons/frames are drawn. Removing all instances of *MenuScale would be a hassle though...
Improvements to better pause menu
- Added ``Enable launcher`` and ``Play startup videos`` ticks; - Automatically turn off antialiasing option while playing in non-fullscreen mode. Also make the tick locked; - Don't used ``True/False`` statements in ``options.ini`` anymore; - Hide ``Open console on error`` option when the ``Enable console`` is turned off. Note: Use ``PlayStartup`` variable in ``PlayStartupVideos`` function when the PR ``Better PlayStartupVideos function Regalis11#205`` will be merged.
- Used ``ResetInput`` to prevent clicking on the locked button while quitting the game; - Added ``HidePointer`` while loading a game.
|
Advanced
tab;Load Game
button while playing onPerma Death
mode;Initial commit without buttons name capitalization: 17203591f83dc92267bbcccf570e06c9fc579ca2
Before:
After: