-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add tooltip js to pages that have codeblocks with actions #2120
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +3 B (0%) Total Size: 208 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we lazy load tooltip in the codeblock definition when the actions property changes?
My thoughts exactly. See companion issue: #2121 |
@bennypowers if you think we should convert this PR to include that fix I'll do so. Just let me know. |
yes please |
What I did
rh-tooltip.js
to pages that loadrh-code-block
with actionsCloses #2050
Testing Instructions
Notes to Reviewers