fix(pagination): Colors, right to left demo, and logical properties #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +32 B (+0.02%) Total Size: 208 kB
ℹ️ View Unchanged
|
bennypowers
requested changes
Jan 13, 2025
| @@ -20,17 +20,23 @@ | |||
| gap: var(--rh-space-2xl, 32px) calc(var(--rh-space-xs, 4px) / 2); | |||
| flex-wrap: wrap; | |||
|
|
|||
| --rh-pagination-accent-color: var(--rh-color-interactive-primary-default); | |||
| /* stylelint-disable-next-line */ | |||
There was a problem hiding this comment.
why do we have to disable this rule? it's there for a reason. perhaps there's a bug lower down in the stack we need to fix? Try putting it in a surface.
There was a problem hiding this comment.
Thanks for the review.
This is the same issue we're seeing in this comment on #2043.
If pagination is not wrapped in a surface, the tokens are undefined; thus, all the colors are incorrect. See the note in this PR's body under "Notes to reviewers".
bennypowers
reviewed
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
<a>tags in theopenvariantwidth/height/top/bottometc to use logical propertiesTesting Instructions
<input>Notes to Reviewers
Ensure that this is the proper way to handle adding fallback colors to things like
--rh-color-interactive-primary-default.Note: the color context demo on uxdot works because the component is wrapped in a
<rh-surface>. These fallbacks are in place for when the component is not wrapped in a<rh-surface>component.