Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] <rh-dialog>: switch to native <dialog> element #1242

Open
brianferry opened this issue Sep 27, 2023 · 0 comments · May be fixed by #2078
Open

[feat] <rh-dialog>: switch to native <dialog> element #1242

brianferry opened this issue Sep 27, 2023 · 0 comments · May be fixed by #2078
Assignees

Comments

@brianferry
Copy link
Collaborator

Description

<rh-dialog> should be set up to use the native <dialog> element if possible and decouple from using the PfModal Base Class.

Suggested solution

Switch over the code and the styles from PfModal to be in the <rh-dialog> element first of all, then convert it to a native <dialog> html element inside the shadow dom.

Example API

Same slots and api as currently exists, just updated internals

Additional context

No response

@bennypowers bennypowers changed the title [feat] <rh-dialog> switch to native <dialog> element [feat] <rh-dialog>: switch to native <dialog> element Oct 31, 2023
@adamjohnson adamjohnson linked a pull request Sep 13, 2024 that will close this issue
5 tasks
@adamjohnson adamjohnson moved this from Todo to In Progress 🟢 in Red Hat Design System Sep 16, 2024
@adamjohnson adamjohnson linked a pull request Dec 6, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress 🟢
4 participants