[bug] <rh-dialog> keyboard focus issue

[heyMP]

Describe the bug

Triggering an rh-dialog component to "open" via a keyboard, the focus doesn't correctly transition from the trigger button to the open dialog. The focus remains on the trigger.

Which Component?

rh-dialog

Steps to reproduce

1. Go to https://ux.redhat.com/elements/dialog/demo/
2. Using your keybaord, tab to the first "open" button
3. Hit "Enter"
4. Verify that the focus has remained on the "open"button

Expected behaviour

The focus should move the the dialog element when the trigger is clicked and focus moved back to the trigger button when the dialog is closed

Screenshots

Element HTML

No response

Operating System (OS)

macOS

Browser

Chrome

More browser information

No response

Additional Info

No response

[heyMP]

I have a fix from rhpt-elements that I can put into a PR.

[bennypowers]

we should just use <dialog> internally https://caniuse.com/dialog

[brianferry]

@bennypowers - Switching to dialog internally was going to be the follow up #1242

[bennypowers]

<dialog> provides browser-built-in focus trap. should we spend time implementing that in javascript now then immediately turn around and delete that code? even if it's blocking release, we might reasonably estimate the amount of testing and qa of both approaches to be roughly equivalent. wdyt @nikkimk ?

[markcaron]

@adamjohnson can you look into this for Clefairy?

[markcaron]

Seems like this may now be something that could be fixed in #1242