Change toggle sidebar button ID to the correct one #4242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izationOperation.
… iOS AppAssets classes.
Fix account add crash
1. bring code from https://github.com/Ranchero-Software/RSParser/pull/78/files to main.
…o-in-readme Mention .xcodeproj in readme instead .xcworkspace
…liseconds_fix_to_main Bring extra-milliseconds fix to main
Fix OpenAllStarredArticles.applescript
|
Thanks for fixing this issue. Could you please resolve the merge conflicts @lolindrath ? |
ankushkushwaha
approved these changes
Sep 23, 2024
|
@ankushkushwaha Thank you! Conflicts fixed! |
rushsteve1
added a commit
to rushsteve1/NetNewsWire
that referenced
this pull request
Oct 20, 2024
Fixes the ID of the sidebar from toggleSidebar to the correct sidebarToggle Replaces: Ranchero-Software#4242 Closes: Ranchero-Software#4103 Co-authored-by: Andy Williams <[email protected]>
rushsteve1
added a commit
to rushsteve1/NetNewsWire
that referenced
this pull request
Oct 20, 2024
Fixes the ID of the sidebar from toggleSidebar to the correct sidebarToggle Adds the sidebarToggle button to the default toolbar This should not affect existing users unless they drag the default toolbar but should affect new users Replaces: Ranchero-Software#4242 Closes: Ranchero-Software#4103 Co-authored-by: Andy Williams <[email protected]>
rushsteve1
added a commit
to rushsteve1/NetNewsWire
that referenced
this pull request
Oct 20, 2024
Fixes the ID of the sidebar from `toggleSidebar` to the correct `sidebarToggle` Adds the sidebarToggle button to the default toolbar. This should not affect existing users, unless they drag the default toolbar but *should* affect new users. Replaces: Ranchero-Software#4242 Closes: Ranchero-Software#4103 Co-authored-by: Andy Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4103
UIKit printed out a debug message that the wrong ID was used. This fixes it and now it appears in the toolbar
@brentsimmons my best guess is your system saved the correct ID somewhere so it continued to work 🤷♂️