feat(module): add option to enable/disable global app middleware #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CavalcanteLeo
requested changes
Sep 13, 2023
| versions: MinimumBrowsersVersion; | ||
| redirect?: string; | ||
| versions?: MinimumBrowsersVersion; | ||
| globalAppMiddleware?: boolean |
There was a problem hiding this comment.
only global I think is fine
| @@ -36,10 +37,19 @@ export default defineNuxtModule<ModuleOptions>({ | |||
| }, | |||
| }, | |||
| }, | |||
|
|
|||
| defaults: { | |||
| globalAppMiddleware: true | |||
There was a problem hiding this comment.
only global I think is fine
| @@ -52,6 +52,7 @@ export default defineNuxtConfig({ | |||
| "Internet Explorer": null, | |||
| "Unknown Browser": 12, | |||
| }, | |||
| globalAppMiddleware: true, | |||
There was a problem hiding this comment.
only global I think is fine
| addRouteMiddleware("supportedBrowsers", supportedBrowsers, global); | ||
| const { globalAppMiddleware } = useRuntimeConfig().public.supportedBrowsers | ||
| addRouteMiddleware("supportedBrowsers", supportedBrowsers, { | ||
| global: globalAppMiddleware |
There was a problem hiding this comment.
only global I think is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new option
globalAppMiddlewareto enable/disable global app middleware.If global is disabled, it can be enabled per page by adding
definePageMeta({ middleware: 'supportedBrowsers' })