Provide unsurprising behavior for tensile threads #1469
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellosel
requested review from
jichangjichang,
KKyang,
vin-huang,
imcarsonliao,
hcman2,
Serge45,
Jinp800125,
TonyYHsieh and
solaslin
as code owners
|
should we notify build team to limit the number of parallel jobs at their end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On two occasions now I've helped users untangle surprising behavior when attempting to pass parallelization settings to TensileCreateLibrary. This PR corrects some of the issues that cause the surprising behavior such as a cap at 64 threads. We have users that want to request 128 and 256 parallel jobs.
Having made these changes, we need to confirm that the CI configuration is still throttling to avoid OOM issues (see https://github.com/ROCm/rocJenkins/pull/919). The rocJenkins PR was merged so we should be ok.
FYI @loggrado @amd-aakash