Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README.md for TensileLite #1466

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Create README.md for TensileLite #1466

merged 4 commits into from
Jan 6, 2025

Conversation

KKyang
Copy link
Contributor

@KKyang KKyang commented Dec 19, 2024

No description provided.

@KKyang KKyang added noCI Disable testing on supported CI systems: math libraries CI has this feature enabled.. ci:docs-only Only run Read the Docs CI on this PR labels Dec 19, 2024

```
make co TENSILE_OUT=tensile-out ARCH="gfx942:xnack-" WAVEFRONTSIZE="-mwavefrontsize64"
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For gfx942 example, it is better to remove WAVEFRONTSIZE="-mwavefrontsize64" since it is default setting
add another example for Wave32?
WAVE=32
example: make co TENSILE_OUT=tensile-out ARCH="gfx1201" WAVE=32

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not, sometimes these settings aren't automatically set correctly

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which condition would make setting incorrect? We may list that in the README as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellosel do you find out why sometimes the architecture cannot be detected correctly?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARCH should use gfx942 (not gfx942:xnack-)

@amd-jnovotny
Copy link
Contributor

@KKyang Should we be adding this to the ROCm documentation? This is inside the tensilelite directory, so out of our scope, but if you want me to review it, let me know.

@KKyang
Copy link
Contributor Author

KKyang commented Jan 2, 2025

@KKyang Should we be adding this to the ROCm documentation? This is inside the tensilelite directory, so out of our scope, but if you want me to review it, let me know.

It's for hipBLASLt developers. Currently we have no plan to add it to the ROCm documentation.

@KKyang KKyang requested a review from jichangjichang January 6, 2025 07:14
hcman2
hcman2 previously approved these changes Jan 6, 2025
@KKyang KKyang merged commit bafc310 into develop Jan 6, 2025
2 checks passed
@KKyang KKyang deleted the tf-readme branch January 6, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs-only Only run Read the Docs CI on this PR noCI Disable testing on supported CI systems: math libraries CI has this feature enabled..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants