Fix argument list too long error #2074
Open
+23
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style: OS independent HIP version printing 2 style: OS independent HIP version printing 3 style: OS independent HIP version printing 4 style: OS independent HIP version printing 5 style: OS independent HIP version printing 6
bstefanuk
requested review from
babakpst,
yoichiyoshida,
bragadeesh and
AlexBrownAMD
as code owners
ellosel
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Extended tests are failing because the argument list is exceeding the command line limit for certain tests. This was caused by a previous change whereby absolute paths are used in the link functions, adding to the number of characters passed to the link command.
Outcomes:
If the number of characters exceeds the command line limit, a response file is used.
Testing and Environment:
Problematic test command
Docker: HIP version 6.3.42131-ade1a3467, Python 3.10.12, Ubuntu 22.04.5 LTS