pkg/nimble: Update to 1.8.0

[chrysn]

Contribution description

This updates nimble, with all the adjustments that need to go with it.

Testing procedure

• make -C examples/nimble_heart_rate_sensor all flash term on any supported board (I'm using on nrf52dk)
• Use a Chrome based browser on https://webbluetoothcg.github.io/demos/heart-rate-sensor/ or any other BLE tool to read out some heart rate.

Issues/PRs references

Updating this is a prerequisite to using ready-made Rust wrappers on nimble (eg. https://github.com/embassy-rs/trouble/), which is preferable over safely wrapping the whole API surface just once ore.

Current status

Not getting it to build yet; we'll need some patches for upstream problems (not following IWYU) and our dead-code strictness -- and then (currently: after fixing them manually), a few symbols are missing, which should be easy to fix but is still a tedious task.

[edit: It builds now and is tested]

All patches should be upstreamed.

[edit: All applicable patches are filled upstream.]

[riot-ci]

Murdock results

✔️ PASSED

16692a9 DO NOT MERGE: Disable nimble on ESP32

Success	Failures	Total	Runtime
10222	0	10222	16m:15s

Artifacts

• Documentation preview

[chrysn]

@sjanc, could you help me here? I'm always running into g_ble_ll_data.ll_evq being uninitialized; the place where it would be initialized is ble_ll_init, but that is called from nowhere. Should I just call that (using an exern void ble_ll_init(void) because it's not even in headers), and should it come before or after nimble_port_init?

[sjanc]

@sjanc, could you help me here? I'm always running into g_ble_ll_data.ll_evq being uninitialized; the place where it would be initialized is ble_ll_init, but that is called from nowhere. Should I just call that (using an exern void ble_ll_init(void) because it's not even in headers), and should it come before or after nimble_port_init?

ble_ll_init() is initializing controller part and on Mynewt it is called from generated sysinit calls, so yes, you'll have to use extern in port (at least for now). It shall be called before ble_transport_hs_init() and ble_transport_ll_init() calls [1][2]

I think you should update nimble_port_init() to adjust for those changes as controller port is very HW/OS specific...
So call to ble_ll_init() should be from nimble_port_init() with proper orders to keep init order requirements.

[1] https://github.com/apache/mynewt-nimble/blob/master/nimble/controller/pkg.yml#L45
[2] apache/mynewt-nimble#1648

[chrysn]

Thanks; moved into a patch while we're aiming for 1.8.0, and filed as apache/mynewt-nimble#1956. All patches that are now applied are submitted upstream (one even already merged), with the exception of a dead code one where I'm not sure whether this shouldn't better be handled by a less pedantic flag set through our build system.

Builds pass, and I've not only used this with the heart rate example described in tests, but also to set up an IPSP interface.

I'm placing this as ready-for-review -- if the ESP thing can be sorted out quickly, I have some remaining hope to get this in before soft freeze.

[chrysn]

Seems the ESP port is maintained by the ESP vendor, who announced updating weeks ago, but we'll need an ESP update.

[maribu]

I recall that for lvgl we had two packages for some time when upstream did a major release (with breaking API changes).

I wonder if that approach to keep both versions as separate packages and let ESP only work with the old one would be the way to unblock this here.