Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: const/var props in loops/functions #7085

Merged
merged 13 commits into from
Jan 2, 2025
Merged

fix: const/var props in loops/functions #7085

merged 13 commits into from
Jan 2, 2025

Conversation

gimonaa
Copy link
Contributor

@gimonaa gimonaa commented Nov 22, 2024 •
edited by Varixo
Loading

// edit by Varixo

  • fix event handlers in loops
  • fix functions props

@gimonaa gimonaa requested a review from a team as a code owner November 22, 2024 05:36
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 997b672

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo
Copy link
Member

Varixo commented Nov 22, 2024

Hey, are you working on a fix or just adding the failing test case?

@gimonaa
Copy link
Contributor Author

gimonaa commented Nov 22, 2024

Hey, are you working on a fix or just adding the failing test case?

Only test

@Varixo
Copy link
Member

Varixo commented Nov 29, 2024

I have fixed the JS part of this problem. There is the optimizer bug atm to solve.
The optimizer incorrectly marks the arguments of the onResolved function as constprops instead of varprops

@Varixo Varixo self-assigned this Nov 29, 2024
@Varixo Varixo changed the title fix: add v2 test - should update elements correctly fix: update onResolved for resource Dec 5, 2024
@Varixo Varixo mentioned this pull request Dec 18, 2024
Closed
@Varixo Varixo force-pushed the test-v2-useResource branch from 6d0fbaa to 1b54c66 Compare December 18, 2024 21:09
@Varixo Varixo changed the title fix: update onResolved for resource fix: const/var props in loops/functions Dec 18, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 18, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7085

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7085

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7085

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7085

commit: 997b672

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 997b672

@Varixo Varixo requested a review from wmertens December 18, 2024 21:36
@Varixo Varixo requested a review from wmertens December 29, 2024 19:53
@Varixo Varixo force-pushed the test-v2-useResource branch from 8f4e541 to e26a525 Compare December 29, 2024 20:16
@Varixo Varixo linked an issue Dec 29, 2024 that may be closed by this pull request
[🐞] v2: captured scope doesn't update in csr #7032
Closed
wmertens
wmertens reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think it's better but now it's rerendering inline components on every change.

If we keep it like that we should benchmark lists of components vs inlines

packages/qwik/src/core/tests/use-lexical-scope.spec.tsx Outdated Show resolved Hide resolved
packages/qwik/src/core/use/use-resource.ts Show resolved Hide resolved
...rc/optimizer/core/src/snapshots/qwik_core__test__destructure_args_inline_cmp_block_stmt.snap Outdated Show resolved Hide resolved
...c/optimizer/core/src/snapshots/qwik_core__test__destructure_args_inline_cmp_block_stmt2.snap Outdated Show resolved Hide resolved
...src/optimizer/core/src/snapshots/qwik_core__test__destructure_args_inline_cmp_expr_stmt.snap Outdated Show resolved Hide resolved
...c/optimizer/core/src/snapshots/qwik_core__test__should_wrap_inner_inline_component_prop.snap Show resolved Hide resolved
packages/qwik/src/optimizer/core/src/transform.rs Show resolved Hide resolved
@Varixo Varixo force-pushed the test-v2-useResource branch from f662fda to 997b672 Compare January 2, 2025 09:11
wmertens
wmertens approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😎

@Varixo Varixo merged commit 9b71fc0 into QwikDev:build/v2 Jan 2, 2025
22 checks passed
@github-actions github-actions bot mentioned this pull request Dec 31, 2024
Open
@Varixo Varixo mentioned this pull request Jan 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Varixo Varixo Varixo left review comments

@wmertens wmertens wmertens approved these changes

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐞] v2: captured scope doesn't update in csr
3 participants
@gimonaa @Varixo @wmertens