refactor: v2 release #6903

wmertens · 2024-09-22T19:36:11Z

This PR is for showing progress on v2, and having installable npm packages.

DO NOT MERGE

The changes are meant to be readable and maintainable, so if things are unclear please let us know.

changeset-bot · 2024-09-22T19:36:15Z

🦋 Changeset detected

Latest commit: 6ed1284

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@qwik.dev/core	Patch
eslint-plugin-qwik	Patch
@qwik.dev/react	Patch
@qwik.dev/router	Patch
create-qwik	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/qwik/src/core/v2/client/dom-container.ts

packages/qwik/src/core/v2/client/vnode.ts

pkg-pr-new · 2024-09-23T08:08:51Z

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@6903

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@6903

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@6903

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@6903

commit: 9b71fc0

github-actions · 2024-09-23T08:09:11Z

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	`9b71fc0`

packages/qwik/src/core/client/dom-container.ts

+        }
+        errorDiv.setAttribute('q:key', '_error_');
+        const journal: VNodeJournal = [];
+        vnode_getDOMChildNodes(journal, vHost).forEach((child) => errorDiv.appendChild(child));


packages/qwik/src/core/client/vnode.ts

+        } else if (key === 'value' && key in element) {
+          (element as any).value = escapeHTML(String(value));
+        } else if (key === dangerouslySetInnerHTML) {
+          (element as any).innerHTML = value!;


To fix the problem, we need to ensure that any content assigned to innerHTML is properly sanitized to prevent XSS attacks. The best way to fix this is to use a library like DOMPurify to sanitize the HTML content before setting it. This approach ensures that any potentially dangerous HTML content is cleaned, removing any malicious scripts or tags.

Import the DOMPurify library.

Use DOMPurify.sanitize to clean the value before assigning it to innerHTML.

packages/qwik/src/core/client/vnode.ts

+        const insertBefore = journal[idx++] as Element | Text | null;
+        let newChild: any;
+        while (idx < length && typeof (newChild = journal[idx]) !== 'number') {
+          insertParent.insertBefore(newChild, insertBefore);


fix(computed): retry qrl execution on throwing promise

fix: repl tabs

fix: convert destructured string prop to props variable

Co-authored-by: Steff <[email protected]>

fix: destructured props for inline components

fix: serialize var prop

fix: updating signal-based var props

fix: textarea with null value

fix: moving existing virtual node during vnode diffing

fix: add and remove var prop attribute

fix: const/var props in loops/functions

fix: finding context parent and sorting projections in the scheduler

wmertens added the VERSION: upcoming major label Sep 22, 2024

github-advanced-security bot found potential problems Sep 22, 2024

View reviewed changes

packages/qwik/src/core/v2/client/dom-container.ts Fixed Show fixed Hide fixed

packages/qwik/src/core/v2/client/vnode.ts Fixed Show fixed Hide fixed

packages/qwik/src/core/v2/client/vnode.ts Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Sep 26, 2024

View reviewed changes

wmertens changed the title ~~refactor: v2 framework rewrite~~ refactor: v2 release Oct 8, 2024

shairez and others added 2 commits October 17, 2024 12:50

fixed build.full

fddc67e

Merge branch 'main' into build/v2

1fa3cc3

wmertens marked this pull request as ready for review October 17, 2024 21:25

wmertens requested review from a team as code owners October 17, 2024 21:25

shairez and others added 17 commits October 18, 2024 02:53

Merge branch 'build/v2' into pr-changesets-v2-alpha

7a30ec9

fix import order

b96bfc9

fix build

2321b79

fix insights

1e26fbd

attempt to fix insights build on CI

9fb3155

fixed rust snapshot test

285e7a0

fix: workspace dep versions + remove builder

3d4aa14

fix(rust): accept test changes

6eeba77

repl: compress base example

161c1b4

fixed CI when building Qwik

5f423fe

retry qrl execution on throwing promise

3911854

Merge pull request #6992 from QwikDev/v2-retry-on-throw-promise

80086ce

fix(computed): retry qrl execution on throwing promise

updated qwik.dev in repl

ba3448e

fix repl share test

d556060

fixed insights build

45990f5

disabled validate..cli for V2 temporarily

2c61e58

temporarily removed --compact mode from pkg.pr.new

185997c

Varixo and others added 30 commits December 21, 2024 10:05

Merge pull request #7189 from QwikDev/v2-fix-repl-2

6f98088

fix: repl tabs

add changesets

5408c40

fix: convert destructured string prop to props variable

1413bc0

Merge pull request #7191 from QwikDev/v2-destructuring-colon-prop

7160354

fix: convert destructured string prop to props variable

fix: destructured props for inline components

48af55c

fix: string prop destructuring

d8a19ca

remove tests duplicates

d266bdd

fix: serialize var prop

6578707

add error location to textarea and ref errors

bfb07d9

fix: updating signal-based var props

0166199

Co-authored-by: Steff <[email protected]>

Merge pull request #7190 from QwikDev/v2-inline-destructured-props

2a60951

fix: destructured props for inline components

Merge pull request #7193 from QwikDev/v2-fix-serialize-var-prop

d21ff10

fix: serialize var prop

fix: textarea with null value

ef92d10

Merge pull request #7198 from QwikDev/v2-updating-var-props

cef6a0d

fix: updating signal-based var props

Merge pull request #7196 from QwikDev/v2-textarea-null-value

c029c32

fix: textarea with null value

fix: finding context parent and sorting projections in the scheduler

58ba5b4

fix: add and remove var prop attribute

fbbfb21

update qwik-ui

2ff2551

better use-resource comment

81a2f7b

fix: for of handlers as var prop

834a451

add test for moving has_const condition

da226e5

Merge branch 'build/v2' into pr/gimonaa/7085

f346257

fix snapshots and tests after merge

e26a525

fix: moving existing virtual node during vnode diffing

08cb7c4

Merge pull request #7208 from QwikDev/v2-fix-moving-found-vnode

0bc9555

fix: moving existing virtual node during vnode diffing

Merge pull request #7206 from QwikDev/v2-fix-release-bugs

31cd137

fix: add and remove var prop attribute

fix: top level inline components props

90a6ede

extend use-lexical-scope test

997b672

Merge pull request #7085 from gimonaa/test-v2-useResource

9b71fc0

fix: const/var props in loops/functions

Merge pull request #7204 from QwikDev/v2-find-context-error

6ed1284

fix: finding context parent and sorting projections in the scheduler

@@ -1 +1,2 @@
+            import DOMPurify from 'dompurify';
             /**
@@ -895,3 +896,3 @@
                     } else if (key === dangerouslySetInnerHTML) {
-                      (element as any).innerHTML = value!;
+                      (element as any).innerHTML = DOMPurify.sanitize(value!);
                     } else {

@@ -10,3 +10,4 @@
               "dependencies": {
-                "csstype": "^3.1"
+                "csstype": "^3.1",
+                "dompurify": "^3.2.3"
               },

Package	Version	Security advisories
dompurify (npm)	3.2.3	None

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: v2 release #6903

refactor: v2 release #6903

wmertens commented Sep 22, 2024 •

edited

Loading

changeset-bot bot commented Sep 22, 2024 •

edited

Loading

pkg-pr-new bot commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

refactor: v2 release #6903

Are you sure you want to change the base?

refactor: v2 release #6903

Conversation

wmertens commented Sep 22, 2024 • edited Loading

changeset-bot bot commented Sep 22, 2024 • edited Loading

🦋 Changeset detected

pkg-pr-new bot commented Sep 23, 2024 • edited Loading

github-actions bot commented Sep 23, 2024 • edited Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

wmertens commented Sep 22, 2024 •

edited

Loading

changeset-bot bot commented Sep 22, 2024 •

edited

Loading

pkg-pr-new bot commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 23, 2024 •

edited

Loading