Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout mode #1262

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Layout mode #1262

wants to merge 13 commits into from

Conversation

edgan
Copy link

@edgan edgan commented Dec 6, 2024

Features:

  1. Always Preview
  • It always shows an preview image for a post instead of just a thumbnail.
  1. Card
  • It is like Always Preview. The order is title, image, subtitle, and comments button instead of title, subtitle, comments button, and image. I prefer this mode given the large images. This order naturally makes the comment button more accessible.
  1. Layout mode
  • Preference in the Images section of settings to switch between Thumbnails(Default), Always Preview, and Card
  1. Added image preview in the post header for Always Preview and Card
  2. Added image preview for reddit album/gallaery posts in Always Preview and Card

I tested toggling between all three modes repeatedly. I also made sure the layout was as expected per mode. I did this testing on my Google Pixel 8 Pro running Android 15.

I did the translations for languages that I could find the prefs_category_images_video string within the file for that language. I double checked the translations. Added dates to the translation additions to follow what seem be a convention.

IMHO, all these features combined massive improves the usability in image dominated subreddits like /r/pics.

Layout modes:
Screenshots

Layout mode preference:
Screenshot

RedReader Post header preview:
Screenshots

RedReader reddit album/gallery image preview:
Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant