-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix menus for macOS #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The help menu works for me as well, so that's good! There are a few small issues that should be easy to fix.
One thing I noticed in the videos is that the app name in the menu is just "Electron." According to this StackOverflow page, to fix that you need to set the productName
in package.json and package the app (you can do that with npm run make
). That would be nice, as long as it doesn't take more than a few minutes.
And finally, since the menu changed, parts of the help page are out of date. I don't mind updating it once all the other changes are made.
That was just for testing it works with the packaged app as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for taking care of this!
Turns out some of the menus (like the help menu) need to be handled differently for macOS because they're system menus that are expected to be present and standard for most apps.
I used this examplefrom the electron docs as a template.
On macOS before:
Screen.Recording.2023-12-20.at.07.28.57.mov
On macOS after:
Screen.Recording.2023-12-20.at.07.28.04.mov