remove sync_compatible from git_clone
#16340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzstoatzz
force-pushed
the
remove-sync-compat-git-clone
branch
from
b4fe05a to
d5fc978
Compare
CodSpeed Performance ReportMerging #16340 will not alter performanceComparing Summary
|
zzstoatzz
force-pushed
the
remove-sync-compat-git-clone
branch
from
371ddf8 to
6ce6969
Compare
zzstoatzz
added
development
desertaxle
reviewed
Dec 11, 2024
tests/deployment/test_steps.py
Outdated
Comment on lines
521
to
527
| result = await run_step( | ||
| { | ||
| "prefect.deployments.steps.git_clone": { | ||
| "repository": "https://github.com/org/repo.git" | ||
| } | ||
| } | ||
| ) |
There was a problem hiding this comment.
Can you add a test that runs agit_clone via this syntax? Just want to make sure that async-only steps work as expected.
There was a problem hiding this comment.
added in 49299e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #15008 and #16292