refactor: centralize error messages #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Error messages are scattered everywhere. This hurts maintainability.
Solution
Centralize error messages into a single module.
I've used the same technique done in PostgREST: an observation type plus a callback that acts upon it.
Notes
I also tried to make the functions pure (and return an error type) but this is more cumbersome because some of extra parameters would need to be allocated to be passed.
At least non-pure functions now have a "marker" (explicit observation handler as a parameter).