Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: playback scene snags #27662

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: playback scene snags #27662

wants to merge 3 commits into from

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Jan 18, 2025

1) a few people have though they can export a recording to video

we already have a way of presenting exports in insights

Screenshot 2025-01-17 at 22 42 11

but we do it differently in replay, let's not

before after
Screenshot 2025-01-17 at 22 43 52 Screenshot 2025-01-17 at 23 03 22

2) a few people have wanted a way to toggle all filters at once

maybe simpler in code to add "All" to the drop down but I didn't like the checkmark behaviour so...

i changed them to buttons with side actions.

  • clicking the button toggles all
  • button is disabled if there are no filterable items
  • button has side action to let you toggle filterable items individually
  • if the feature is disabled the side action is a link to config to turn it on

2025-01-18 02 01 22

Copy link
Contributor

github-actions bot commented Jan 18, 2025

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.13 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants