feat: [1/n] Teams Downgrade Flow Experiment #27617
Open
+124
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +44 B (0%) Total Size: 1.13 MB ℹ️ View Unchanged
|
surbhi-posthog
changed the title
joshsny
approved these changes
Jan 17, 2025
| @@ -36,6 +38,8 @@ export const BillingProductAddonActions = ({ addon, productRef }: BillingProduct | |||
| cancelTrial, | |||
| } = useActions(billingProductLogic({ product: addon })) | |||
| const { featureFlags } = useValues(featureFlagLogic) | |||
| const { showDowngradeModal } = useActions(downgradeLogic) | |||
| const { isUserInExperiment } = useValues(downgradeLogic) | |||
There was a problem hiding this comment.
nit: make this more specific e.g. isUserInDowngradeFlowExperiment
| listeners(({ actions, values }) => ({ | ||
| handleDowngrade: async () => { | ||
| if (values.currentAddon) { | ||
| const logic = billingProductLogic({ product: values.currentAddon }) |
There was a problem hiding this comment.
Some random kea related questions:
How does this work with pulling in a logic directly, do we need to mount it?
Is this a common kea pattern, or is it more common to use connect? Not sure if using connect is possible here given you need to pass a product?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a user unsubscribes from the teams feature, we want to show them a list of features that they are currently using and will lose access to.
Changes
In this PR, I'm doing the initial experiment setup and showing the user a basic modal before they can unsubscribe. Next I will add logic to check which features are actually used by the org and update the list.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Cloud: Yes
How did you test this code?
This is an old video, but the flow is the same where the unsubscribe survey opens after the modal
Screen.Recording.2025-01-14.at.2.25.13.PM.mov
Verified modal pops up before they are allowed to unsubscribe.
Verified that the user only sees the new flow if they are in the experiment group