Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SolidJS app #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

charlyisidore
Copy link

This PR adds a SolidJS todo app (written in TypeScript).

If you have suggestions or questions, please let me know :)

@Pierstoval
Copy link
Owner

Thanks, looks neat!

Can it be installed with "yarn" instead of "pnpm"?

I don't (yet?) have differenciation in these benchmarks between package managers, and we know yarn, npm and pnpm have different performances at install time, so I don't want to pollute the benchmarks with irrelevant data.

If you can rewrite the installation process with "yarn" it would be great 👍

@charlyisidore
Copy link
Author

Thanks, looks neat!

Can it be installed with "yarn" instead of "pnpm"?

I don't (yet?) have differenciation in these benchmarks between package managers, and we know yarn, npm and pnpm have different performances at install time, so I don't want to pollute the benchmarks with irrelevant data.

If you can rewrite the installation process with "yarn" it would be great 👍

Yes, it can be installed with yarn without any problem. The PR includes the yarn.lock file.

The pnpm-lock.yaml file was from the SolidJS template and is not necessary, I just removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants