-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$component controller and new router #159
$component controller and new router #159
Conversation
… version to latest which allows routes to use components instead templates
@@ -5,3 +5,4 @@ node_modules | |||
.settings | |||
*.log | |||
dist/ | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things like this should be handling via global gitignore.
Cool! The only thing that I don't like in p.s. Also not sure about uiRouter beta release... but I also use it and everything seems to be ok. |
@fesor In the very first look you feel like, there is lot of boilerplate goes on. However I believe it's all for good reason. Specially when you want to test a component with bindings and other dependancies like a service, it's very easy to unit test. Also I have added some additional unit tests for router as well. I started using uiRouter alpha release at work sometime back and I have a very good size team as well. Also recently upgraded to beta version and so far no issues. So I believe that beta release is good enough. The change in .gitignore I have revert it back. Cheers. |
@samithaf thanks again! p.s. maybe we can hide boilerplate in some helper function but I'm not sure. |
Good work, but I think it would have been better to have completed this PR by updating ALL files..the generator template/hero files are still using the old style... looks a bit messy. |
Added PR #165 |
Changes: