Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOT] add simulation support for user-defined iterable objects #70620
base: develop
Are you sure you want to change the base?
[SOT] add simulation support for user-defined iterable objects #70620
Changes from all commits
a4cad8c
03f291d
529e646
9d79212
675f502
edd562a
f02c7da
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这段逻辑对上下文有较大的修改,如何保证全场景的正确性?
每条字节码应该只做自己的事情,只看当前
instruction
,不应该去访问self._instructions
另外这里特判
ContainerVariable
和__iter__
的原因是?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不止 list,应该是现在全部已经支持的 builtin types
另外这个实现在 VariableBase 上会有什么问题么
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议使用
iter(self._list)
,这是更加惯用的形式,不过当前写法也测一下吧There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以新建一个文件用来测 iter,比如
test_iter.py