-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate input objects, start using Nullable #498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbloss
changed the title
WIP: generate input objects, start using Nullable
generate input objects, start using Nullable
Dec 27, 2024
rocktavious
reviewed
Jan 2, 2025
rocktavious
reviewed
Jan 2, 2025
rocktavious
reviewed
Jan 2, 2025
rocktavious
reviewed
Jan 2, 2025
rocktavious
reviewed
Jan 2, 2025
rocktavious
reviewed
Jan 2, 2025
rocktavious
reviewed
Jan 2, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
check_test.go
Outdated
@@ -32,8 +32,9 @@ var ( | |||
Value: ol.RefOf("Requests"), | |||
} | |||
|
|||
equalsEnum = ol.PredicateTypeEnumEquals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed?
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
reviewed
Jan 3, 2025
rocktavious
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #573
🚨 This PR contains BREAKING CHANGES for the upcoming
v2025
opslevel-go release 🚨Run
task gen
to see new code generated ininput.go
Noteworthy Changes
*Nullable[<type>]
type now wraps optional fields of most structs ininput.go
. This sweeping change enables setting input object fields to JSONnull
, resolves ambiguity during API update calls, and completes a planned major refactor before the next major release of opslevel-go.scalar.go
, a newUnmarshalJSON()
forNullable
types was added to correctly unmarshal JSON values to this custom type.task gen
now uses the template intemplates/inputObjects.tpl
to generate everything ininput.go
gen.go
:enumExamples
,listExamples
, andscalarExamples
are used to set values inexample:
struct tagsRefOf()
calls have been replaced withNewNullableFrom()
Checklist