Tagargs changes - from a TODO comment (#372)

.changes/unreleased/Refactor-20240214-132831.yaml

@@ -0,0 +1,3 @@
+kind: Refactor
+body: NewTagArgs(string) will return error if string is not in exact format 'key:value'
+time: 2024-02-14T13:28:31.000636-05:00

service.go

@@ -555,22 +555,20 @@ func (client *Client) ListServicesWithProduct(product string, variables *Payload
 	return &q.Account.Services, nil
 }
 
-func NewTagArgs(tag string) TagArgs {
+func NewTagArgs(tag string) (TagArgs, error) {
 	kv := strings.Split(tag, ":")
 	switch len(kv) {
 	case 1:
 		return TagArgs{
 			Key: RefOf(kv[0]),
-		}
+		}, nil
 	case 2:
 		return TagArgs{
 			Key:   RefOf(kv[0]),
 			Value: RefOf(kv[1]),
-		}
-	default: // TODO: is this the best we can do?
-		return TagArgs{
-			Key: RefOf(tag),
-		}
+		}, nil
+	default:
+		return TagArgs{}, fmt.Errorf("cannot make a valid TagArg from: '%s' (not in format key:value)", tag)
 	}
 }
 

service_test.go

@@ -808,7 +808,9 @@ func TestListServicesWithTag(t *testing.T) {
 
 	client := BestTestClient(t, "service/list_with_tag", requests...)
 	// Act
-	response, err := client.ListServicesWithTag(ol.NewTagArgs("app:worker"), nil)
+	tagArgs, err := ol.NewTagArgs("app:worker")
+	autopilot.Ok(t, err)
+	response, err := client.ListServicesWithTag(tagArgs, nil)
 	result := response.Nodes
 	// Assert
 	autopilot.Ok(t, err)