Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TinyMCE: disable WYSIWYG if not installed #4495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

TinyMCE: disable WYSIWYG if not installed #4495

wants to merge 2 commits into from
+19 −592

Conversation

sreichel
Copy link
Contributor

Manual testing scenarios (*)

  1. composer remove tinymce/tinymce
  2. check admin cms page/block

@github-actions github-actions bot added the Component: Cms Relates to Mage_Cms label Jan 18, 2025
@sreichel sreichel added this to the 20.13.0 milestone Jan 18, 2025
addison74
addison74 previously approved these changes Jan 18, 2025
View reviewed changes
@sreichel sreichel marked this pull request as draft January 18, 2025 22:03
@github-actions github-actions bot added the composer Relates to composer.json label Jan 18, 2025
@sreichel sreichel marked this pull request as ready for review January 18, 2025 23:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fballiano referenced this pull request in MahoCommerce/maho Jan 19, 2025
@fballiano
TinyMCE is now optional and not installed by default in the core
9864522
@sreichel sreichel requested a review from addison74 January 19, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: Cms Relates to Mage_Cms composer Relates to composer.json enhancement
Projects
None yet
Milestone
20.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sreichel @addison74