Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created blog file cloudant-with-open-liberty.adoc #4160

Merged
merged 23 commits into from
Dec 6, 2024
Merged

Conversation

revijay
Copy link
Contributor

@revijay revijay commented Nov 24, 2024

Created blog file cloudant-with-open-liberty.adoc
Issue #4152.

Link to the blog in draft site : https://blogs-draft-openlibertyio.mqj6zf7jocq.us-south.codeengine.appdomain.cloud/blog/2024/11/25/cloudant-with-open-liberty.html

Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements, just a few minor corrections.

@revijay
Copy link
Contributor Author

revijay commented Nov 26, 2024

@mswatosh, thanks for the review. I have incorporated review comments. Please have a look

mswatosh
mswatosh previously approved these changes Nov 26, 2024
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review looks good 👍

GraceJansen
GraceJansen previously approved these changes Nov 27, 2024
Copy link
Member

@GraceJansen GraceJansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding in the intro and summary sections I requested. They read well and I think this post is now ready for publishing. Thanks for your work on this.

@revijay revijay requested a review from mswatosh November 27, 2024 10:21
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things I noticed in the new additions. The IAM section is a great addition

@revijay
Copy link
Contributor Author

revijay commented Nov 27, 2024

Thanks @mswatosh for your detailed review. I made the changes which you suggested.

@revijay revijay requested a review from mswatosh November 27, 2024 15:05
mswatosh
mswatosh previously approved these changes Nov 27, 2024
Copy link
Member

@mswatosh mswatosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I missed some unnecessary parameters in the ibm cloud url earlier, so I added a commit to remove it.

mswatosh
mswatosh previously approved these changes Dec 2, 2024
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @revijay - ID review- I've made a few suggestions and asked a couple questions. If you accept my suggestions, please also commit them back to the draft branch to keep the versions in sync. Once the content is sorted, we can decide a publish date and update the file name accordingly. Let me know if you have any questions. Thanks!

posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
posts/2024-11-25-cloudant-with-open-liberty.adoc Outdated Show resolved Hide resolved
@revijay revijay requested a review from dmuelle December 4, 2024 06:50
Copy link
Member

@dmuelle dmuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@dmuelle dmuelle merged commit 83d1ea0 into staging Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants