Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-14 M1 runner when building macOS ARM wheels #186

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

ConorMacBride
Copy link
Member

@ConorMacBride ConorMacBride commented Feb 13, 2024

This should does enable testing when building macOS ARM wheels.

  • Avoid hardcoding the M1 runner name

@Cadair
Copy link
Member

Cadair commented Feb 13, 2024

ooo! yay!

@ConorMacBride ConorMacBride marked this pull request as ready for review February 13, 2024 20:02
@ConorMacBride
Copy link
Member Author

macos-latest will point to macos-14 anyway around Apr – June 2024 and then I guess macos-latest will always be an arm64 runner. At that point we can just revert this PR.

@Cadair
Copy link
Member

Cadair commented Feb 19, 2024

Aren't we going to need the reverse then? Or can you run and test x86 mac builds on the arm platform?

@Cadair Cadair merged commit 166075e into OpenAstronomy:main Feb 19, 2024
20 checks passed
@ConorMacBride ConorMacBride deleted the m1-runner branch February 20, 2024 19:59
@ConorMacBride
Copy link
Member Author

You can build and test x86 on the Apple ARM systems. Apple have a translator for running x86 on ARM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants