-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update package.nls.json #10933
Open
supkasar
wants to merge
5
commits into
dev
Choose a base branch
from
supkasar-patch-2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the grammar in the content. Simplified it to make it concise, clear, and consistent throughout.
supkasar
requested review from
timngmsft,
sffamily and
therealjohn
as code owners
February 27, 2024 08:11
Unit test updated
supkasar
requested review from
xzf0587,
frankqianms,
blackchoey and
adashen
as code owners
February 28, 2024 07:13
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #10933 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 463 463
Lines 28133 28133
Branches 5637 5637
=======================================
Hits 24579 24579
Misses 1778 1778
Partials 1776 1776 |
sffamily
previously approved these changes
Mar 4, 2024
frankqianms
previously approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
sffamily
approved these changes
Mar 13, 2024
sffamily
previously approved these changes
Apr 3, 2024
sffamily
approved these changes
Apr 28, 2024
therealjohn
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the grammar in the content. Simplified it to make it concise, clear, and consistent throughout.