Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable e2e tests & add store size interface & add filter params for ics #2647

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

YinHang2515
Copy link
Contributor

For more information about how to contribute to this repo, visit this page.

Description

re-add otherAppState and Store e2e tests & add store size interface

Main changes in the PR:

  1. e2e-test-data: otherAppState.json & store.json
  2. store.ts

Validation

Validation performed:

  1. use store.json e2e test file

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

No. No need for this change

End-to-end tests added:

Yes

Additional Requirements

Change file added:

Yes

@YinHang2515 YinHang2515 requested a review from a team as a code owner December 4, 2024 08:29
@YinHang2515
Copy link
Contributor Author

pending until hub-sdk pr checked in

Copy link
Contributor

@TrevorJoelHarris TrevorJoelHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate that dialog sizes aren't too small. It will never be valid for a developer to pass up a size <= 0 for either height or width.

@YinHang2515 YinHang2515 changed the title re-add otherAppState and Store e2e tests & add store size interface re-enable e2e tests & add store size interface & add filter params for ics Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants