Use wiremock in integration tests #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_id_artifacts_relatedissues_statistics.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests relied on a TeamCity server being setup in a very specific way.
(eg, it assumed that guest access was enabled, that certain projects existed etc)
This was very difficult to setup a reproducible environment to run the tests against.
I considered using a combination of terraform and teamcity config-as-code, but thought the bang for buck wasn't there - running the tests would involve spinning up a real teamcity server, which takes a while and would likely be a bit challenging.
Instead, I went down the wiremock path, using the record/replay mapping file approach (as opposed to the "set it up in code" approach).
It mostly worked well, but some of the tests were not well suited - some of these were deleted, some were combined and some got turned into scenarios.
Some tests called the same url, but with different user/password, meaning that I had to save the auth header to the files to help distinguish between them. Not ideal, but all passwords used have been rotated and are no longer valid.
While we've got fast, reliable tests, I'm not sure how maintainable they are, nor how well they'll suite us in the future.
Interested in hearing thoughts.