Overhauls sediment #236
Draft
Overhauls sediment #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rebase after #233 is merged |
jagoosw
force-pushed
the
jsw/refactor-sediment
branch
from
8af8c4e to
30db3ce
Compare
|
@ali-ramadhan, this should be pretty much done, I just need the tests to pass and to update the documentation. I think this is a better way todo sediments and should be a lot easier to maintain in the future, do you think it looks okay? |
|
@jagoosw Will try to have a look later today! Hope it's okay that I resolve the merge conflicts so it's easier to review. EDIT: Actually is it okay if I let you resolve the merge conflicts just to ensure I don't butcher your code? Happy to review though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors sediment models to not rely on making a huge mess of the Oceananigans time steppers. Instead, the sediment models are independently integrated during the
update_biogeochemical_state!stage. Sediment models are now also written the same as other models where a developer only has to write forcing functions instead of the monstrosity they would have to put together before. I think that discrete form ones could also support multilayer models without having todo any more interal work.Another thought I had was that now we have
update_boundary_conditions!in Oceananigans, sediment models could actually becomeFluxBoundaryConditionswhich have properties and are integrated during the update stage, but I'm not sure how to nicely set that up.Closes #147 and #234