Data-set-* and Data-suggest-* #4044
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Jan 6, 2025
Comment on lines
-130
to
+131
| data-set-bc-account-other: 'other_account_python27', | ||
| data-set-bc-account: 'python27' | ||
| data-suggest-bc-account-other: 'other_account_python27', | ||
| data-suggest-bc-account: 'python27' |
There was a problem hiding this comment.
You changed all these data-set to data-suggest. This implies to me that there's some compatibility issue with data-set, is there?
There was a problem hiding this comment.
data-set- was behaving how data-suggest- behaves now in some tests. So data-set- was not disabling the set select option before. This does make it a breaking change.
There was a problem hiding this comment.
I guess I'll have to look over the implementation, but I don't think we should break data-set directives. We definitely can't in 4.0, but I wouldn't want to in future versions either really.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2817
Screen.Recording.2025-01-02.at.9.29.43.AM.mov