WIP: Introduce an one-off-build command to reproduce ofBorg locally #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `origin/` prefix will be added by the actual git cloner later on when `co.checkout_origin_ref` is called further down the function.
Motivated by trying to review a change in how ofBorg reports build
errors I started hacking on a command that allowed me to execute just
the build part of ofBorg without setting up a local queue or config
files.
This is still a WIP that is hardcoded to exactly one PR and commit
revision. I plan to convert all the constants to Clap CLI arguments once
I moved the build system of the project to naersk and can then introduce
new dependencies.
Things to be done:
- [ ] Move constants to Clap
- [ ] The system attribute should be defaulted to the current system.
We can use the `target_os` and `target_arch` values for that.
The user should still be able to override thos tho...
- [ ] Make the logging a bit prettier
- [ ] Implement a custom Notification receiver that just logs the
messages as they come in.
- [ ] (idea) add support for the eval part as well so we can run ofBorg
locally just like we can run nixpkgs-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by trying to review a change in how ofBorg reports build
errors I started hacking on a command that allowed me to execute just
the build part of ofBorg without setting up a local queue or config
files.
This is still a WIP that is hardcoded to exactly one PR and commit
revision. I plan to convert all the constants to Clap CLI arguments once
I moved the build system of the project to naersk and can then introduce
new dependencies.
Things to be done:
We can use the
target_osandtarget_archvalues for that.The user should still be able to override thos tho...
messages as they come in.
locally just like we can run nixpkgs-review.