Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmbootstrap: 3.0.0 -> 3.1.0, fix build, tweaking #370313

Merged
merged 1 commit into from
Jan 2, 2025
Merged

pmbootstrap: 3.0.0 -> 3.1.0, fix build, tweaking #370313

merged 1 commit into from
Jan 2, 2025

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Jan 2, 2025

  • pmbootstrap: 3.0.0 -> 3.1.0

Closes #370309

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 2, 2025
@lucasew
Copy link
Contributor Author

lucasew commented Jan 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370313

x86_64-linux

❌ 2 packages failed to build:
  • pmbootstrap
  • pmbootstrap.dist

@lucasew
Copy link
Contributor Author

lucasew commented Jan 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370313

x86_64-linux

✅ 2 packages built:
  • pmbootstrap
  • pmbootstrap.dist

@lucasew lucasew requested review from onny and GaetanLepage January 2, 2025 18:33
@lucasew lucasew changed the title pmbootstrap: 3.0.0 -> 3.1.0 pmbootstrap: 3.0.0 -> 3.1.0, fix build, tweaking Jan 2, 2025
@lucasew lucasew force-pushed the 20250102-upd-pmbootstrap branch from 58af54a to d340ddd Compare January 2, 2025 18:57
@lucasew
Copy link
Contributor Author

lucasew commented Jan 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370313

x86_64-linux

✅ 2 packages built:
  • pmbootstrap
  • pmbootstrap.dist

@lucasew lucasew requested a review from GaetanLepage January 2, 2025 19:04
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370313

x86_64-linux

✅ 2 packages built:
  • pmbootstrap
  • pmbootstrap.dist

GaetanLepage
GaetanLepage requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, diff looks good to me :)
Could you please squash your commits into one now ?

@lucasew lucasew force-pushed the 20250102-upd-pmbootstrap branch from 875841b to 1ac626c Compare January 2, 2025 19:12
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370313

x86_64-linux

✅ 2 packages built:
  • pmbootstrap
  • pmbootstrap.dist

GaetanLepage
GaetanLepage approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks for the fix :)

@GaetanLepage GaetanLepage merged commit 10e1dc5 into NixOS:master Jan 2, 2025
21 of 23 checks passed
@lucasew lucasew deleted the 20250102-upd-pmbootstrap branch January 2, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@onny onny Awaiting requested review from onny

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: pmbootstrap 3.0.0 → 3.1.0
2 participants
@lucasew @GaetanLepage