Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexusmods-app: 0.6.1 -> 0.6.2 #349023

Merged
merged 1 commit into from
Oct 17, 2024
Merged

nexusmods-app: 0.6.1 -> 0.6.2 #349023

merged 1 commit into from
Oct 17, 2024

Conversation

MattSturgeon
Copy link
Contributor

@MattSturgeon MattSturgeon commented Oct 16, 2024

  • Bump version: 0.6.1 -> 0.6.2
  • Disable a newly failing test:
    NexusMods.Networking.ModUpdates.Tests.PerFeedCacheUpdaterTests.Constructor_WithItemsFromDifferentGames_ShouldThrowArgumentException_InDebug
    fails with: Expected a <System.ArgumentException> to be thrown, but no exception was thrown.
  • Upstream's changelog
  • Previous update PR

Notes for end-users

Caution

Before upgrading to a new version of nexusmods-app you will need a fresh start.
If you have configuration leftover from an old version, the updated app will crash.

See upstream's guide on how to uninstall the app.

Tip

You can reset all modded games and wipe your nexusmods-app config using:

NexusMods.App uninstall-app
  • This should be done before updating the app.
  • Be careful: There's no way to recover a wiped config!

Tip

If you've run the appimage version from upstream, or a pre-0.6 nixpkgs version, you may also need to remove old desktop entries to avoid other issues:

rm ~/.local/share/applications/com.nexusmods.app.desktop

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

- Bump version
- Disable a newly failing test
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 16, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 16, 2024
@GGG-KILLER GGG-KILLER added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 17, 2024
@MattSturgeon MattSturgeon requested a review from corngood October 17, 2024 11:51
@corngood
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349023


x86_64-linux

✅ 2 packages built:
  • nexusmods-app
  • nexusmods-app-unfree

@corngood
Copy link
Contributor

All tests passed. I've noticed that some of the tests print:

Fontconfig error: Cannot load default config file: No such file: (null)
Fontconfig error: No writable cache directories
Fontconfig error: No writable cache directories
Fontconfig error: No writable cache directories
Fontconfig error: No writable cache directories

That's not new with this commit, and doesn't seem to cause the tests to fail, but maybe it's interesting.

@MattSturgeon
Copy link
Contributor Author

MattSturgeon commented Oct 17, 2024

All tests passed. I've noticed that some of the tests print [Fontconfig errors]

That's not new with this commit, and doesn't seem to cause the tests to fail, but maybe it's interesting.

I believe I spotted some fontconfig errors while working on the 0.6.1 bump. Can't recall if they were exclusive to tests or also present at runtime...

At the time we had bigger things to worry about, so I let it slip my mind... I haven't noticed any visual issues with font rendering at runtime, but I also have nothing to compare it to.

I think we can just monitor the situation for now and see if any issues crop up?

@corngood
Copy link
Contributor

I think we can just monitor the situation for now and see if any issues crop up?

Yeah, I don't want to hold this up. I just wanted to write it down somewhere.

@corngood corngood merged commit 2026af4 into NixOS:master Oct 17, 2024
63 of 64 checks passed
@MattSturgeon MattSturgeon deleted the nexus-0.6.2 branch October 17, 2024 16:18
@MattSturgeon MattSturgeon mentioned this pull request Nov 6, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants