-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nexusmods-app: 0.6.1 -> 0.6.2 #349023
nexusmods-app: 0.6.1 -> 0.6.2 #349023
Conversation
- Bump version - Disable a newly failing test
|
All tests passed. I've noticed that some of the tests print:
That's not new with this commit, and doesn't seem to cause the tests to fail, but maybe it's interesting. |
I believe I spotted some fontconfig errors while working on the 0.6.1 bump. Can't recall if they were exclusive to tests or also present at runtime... At the time we had bigger things to worry about, so I let it slip my mind... I haven't noticed any visual issues with font rendering at runtime, but I also have nothing to compare it to. I think we can just monitor the situation for now and see if any issues crop up? |
Yeah, I don't want to hold this up. I just wanted to write it down somewhere. |
NexusMods.Networking.ModUpdates.Tests.PerFeedCacheUpdaterTests.Constructor_WithItemsFromDifferentGames_ShouldThrowArgumentException_InDebug
fails with:
Expected a <System.ArgumentException> to be thrown, but no exception was thrown.
Notes for end-users
Caution
Before upgrading to a new version of
nexusmods-app
you will need a fresh start.If you have configuration leftover from an old version, the updated app will crash.
See upstream's guide on how to uninstall the app.
Tip
You can reset all modded games and wipe your nexusmods-app config using:
Tip
If you've run the appimage version from upstream, or a pre-0.6 nixpkgs version, you may also need to remove old desktop entries to avoid other issues:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.