libreoffice-still: 7.1.8.1 -> 7.2.6.2

[gador]

Description of changes

Update to supported libreoffice release

Changelog

fixes #171907

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review run on x86_64-linux 1

11 packages built:

• jpsxdec
• libreoffice (libreoffice-still)
• libreoffice-still-unwrapped
• openlp
• openlpFull
• paperwork
• python310Packages.paperwork-backend
• python310Packages.paperwork-shell
• python39Packages.paperwork-backend
• python39Packages.paperwork-shell
• unoconv

[fogti]

I'm not involved enough to gauge if the download.nix modifications are fine, but the rest looks LGTM.

[gador]

the provided script was used to update download.nix if that helps

[SuperSandro2000]

Why are we not using the system libraries?

[gador]

Because the system library is missing a header file and libreoffice won't compile.
It ships its own version of zxing (which is found in the long download.nix file)

[alexshpilkin]

It seems that the system zxing-cpp is not missing anything and just has its .pc file screwed up, I’ll have a look.

[alexshpilkin]

Ouch, this is worse than I thought. KhronosGroup/SPIRV-Tools#3905 is a similar bug from October 2020 that concerns broken pkg-config files when CMAKE_INSTALL_{INCLUDE,LIB}DIR is absolute (and with the Nixpkgs CMake tooling it is), it’s still unfixed, and the .pc files for spirv-tools in Nixpkgs are similarly broken. Honestly it seems like .pc files in all CMake-built projects should be suspect.

[gador]

ah. interesting. Thanks for clearing that up. When building with the nixos zxing it just complained about a barcode header file not found.
Libreoffice compiles with its own version correctly though 👍

[alexshpilkin]

@gador see #172150 for my attempt at killing the outdated custom zxing (but my machine is likely too puny to build libreoffice so I haven’t tried that yet)

[SuperSandro2000]

Instead of using some version that they vendored which could be missing patches, updates and nixos workaround we should use our version again especially if the pc file bug is fixed.